LCOGT FLI and Sinistro Raw, Calibrated, Derived Data and Documentation Liens
============================================================================

Documentation
=============

--> What was the standard of picking the image quality? Is it recorded somewhere?
--> The PDFs could benefit from a auto batch edit correction for small format issues, such as, "insert a space between words and parentheses", "add a comma after all the e.g. and i.g.", "remove commas before ands" and spell check for small typos.

file: lcogt_dart_uncalibrated_calibrated_sis.pdf 
--> Typo Pg 16: "A separate "documen_lcogt" folder is created"
--> Now that DART is done, some “will” in the documents should be changed to properly reflect that.

file: /data_lcogt/fli*/overview.txt
--> Includes steps for Sinistro that are not relevant to this data set.

file: *_overview.txt
--> Reference the sis file
--> There is no Data Set Overview. Some is in the abstract but I would like to see something like "All provided frames are from 2022-09-26. N frames from site A telescope B in filter C, etc."
-->Basic information would be nice: FOV, pixel size for the different telescopes/instruments. Some frames seem to be tracked sidereally and others are not. Mention this in the overview.


file: fli_description.xml
--> "<description>Describes the Las Cumbres Observatory (LCOGT) FLI Imager, Detector, and Filters.</description>" remove comma before and.


XML Labels
==========

--> Do you mean to include two other description files (for Las Cumbres Observatory and the  1-meter telescope) in this bundle?

Observing_System Context Objects:
--> The collection.xml files have different information/format than what is found in the data products or the document collection.xml.  They should be consistant. For instance:
--> --> Telescope:  In the data collection.xml files, each individual LCOGT 1m NN telescope is listed whereas in the in the data products NN is dropped so all telescope names are the same.  In the data products the unique NN is specified in the description.  In the collection.xml files, the LCOGT name is abbreviated whereas the data products spell it out.
--> --> Instrument: In the collection.xml files it says "Sinistro Camera" whereas in the data products it includes the telescope name.
--> Should each Telescope LCOGT 1m-NN be a unique context object entry or combined into a "Telescopes" entry as is with the ingested context object?  If the former, can they all still point to the same context LID?  
--> The collection.xml does not have any LIDs, whereas the the data products have LIDs, but in some cases they are wrong.  Here are the existing names and LIDs based on the ingested context object files:
--> --> Host: Las Cumbres Observatory (urn:nasa:pds:context:facility:observatory.las_cumbres)
--> --> Telescope: Las Cumbres Global Telescope Network - 1m Telescopes (urn:nasa:pds:context:telescope:las_cumbres.1m0_telescopes)
--> --> Instrument: Las Cumbres 1m Telescopes - Sinistro Camera (urn:nasa:pds:context:instrument:las_cumbres.1m0_telescopes.sinistro)
--> Need to create a context object for the FLI Camera (LID in labels: urn:nasa:pds:context:instrument:las_cumbres.1m0_telescopes.fli)
--> The <description> for each of these context objects says to look in the bundle for their descriptions (where would they look, its a big bundle).  This is not appropriate, especially since  there are only brief descriptions of the instruments found in the document collection, and nothing about the host or telescopes, even though they say to look there.  Please add a brief description here. 

file: '*/collection*.xml'
--> For data_lcgt* (not _fli) files have multiple instances of the same telescopes.  There should only be one instance.  I suggest sorting them by type (as is currently done) and then alphabetically, keeping only one instance of each telescope, assuming we are not combining them all into one instance.
--> There are no context object LIDs for any of the NN telescopes.  Please add.
--> The data files corresponding data_lcogt* and data_lcogt_fli* have the same <title> and <description>.  Should include mention of the Imager (Sinistro vs FLI) to make them unique.  
--> Please update the <title> and <description> for document_lcogt <Identification_Area>, to better conform to what the data collections share.  Currently the description is almost meaningless, and the title should not really have commas.
--> I noticed that there are no editors listed in the Identification_Area, unlike all the other ground_based collections associated with DART.  Is this correct?
--> I would not expect there to be a Target_Identification section for the document collection.  Please remove.
--> Consider making the collection.xml internal reference to the overview document a LIDVID reference instead of LID reference.  This is due to newer versions of an overview document being pointed to by an older version of the collection when the newer version overview document may not correctly apply to it.

file: 'data_lcogt_fliraw/collection_data_lcogt_fliraw.csv'
--> The first LID is wrong.  It is missing the 'w' in 'overview', and should be: urn:nasa:pds:dart_teleobs:data_lcogt_fliraw:collection_data_lcogt_fliraw_overview::1.0

file: 'document_lcogt/collection_lcogtdoc.xml'
--> the <Inventory> <records> should be corrected to 3 from 2.

files: 'data_lcogt*/*/*.xml'
--> The Observing_System context objects have multiple <description> values that include the text: "The description for the host can be found in the document collection for this bundle."  Please remove this text.  Please replace with a brief description.  Also note that there are no such descriptions for the Host, nor Telescope, even though this text implies there is.



Data
====

--> Extensions 2-4 need valid/supported display settings.
--> lcogt_1m0_06_fa07_20221231/  & lcogt_1m0_08_fa05_20230101/  are empty
Please add that all the photometry was converted to PanSTARRS r magnitudes.
And refer to the overview.txt for dart_teleobs/data_lcogtraw for details of the filters used.


Sinistro
--> No calibration files (flats, biases, darks).
--> SIS describes master reduction files but I don’t see them anywhere? Raw frames aren’t very useful without these.
--> Raw image extensions don't match sky orientation. Each extension/amplifier needs its own line_display_direction and sample_display_direction? Or each extension needs flipped properly

FLI
--> Celestial_North_Clock_Angle = 0 deg in labels but In images, North is down (~180 deg). 
--> Some of the WCS solutions are not accurate. Problem is noted and “solved” in the DDP dataset, but not in this one. Document that some of the WCS in the headers data cannot be
trusted and point to DDP dataset.
--> Why does this photometry deviate from all the other datasets (binary FITS table vs ASCII)?
--> fliddp data Set Overview says 11 apertures from 1 to 11, but the table gives 0 to 10.
--> The aperture sizes are not given.
--> column 8. What does the flux radius refer to?

files: 'data_lcogtddp/lcogt*/*photometry.{tab,xml}'
--> The SBN strongly encourages the use of the <field_format> keyword for all fields in a table.  Please add these.
--> Filenames are used to link individual data rows to the source data, but in PDS4 filenames are not fixed nor relevant and may change.  A better field would be to use the LIDVID.


EN Review
=========

urn:nasa:pds:dart_teleobs:data_lcogt_fliraw::1.0

*.xml
- Each file here has 3 lid_references to telescopes and instruments:
  urn:nasa:pds:context:facility:observatory.las_cumbres
  urn:nasa:pds:context:instrument_host:las_cumbres.1m0_telescopes
  urn:nasa:pds:context:instrument:las_cumbres.1m0_telescopes.fli
The first is fine. Can you replace the latter two with the existing:
  urn:nasa:pds:context:telescope:las_cumbres.1m0_telescopes
  urn:nasa:pds:context:instrument:las_cumbres.1m0_telescopes.sinistro
Note that instrument_host in PDS4 is for spacecraft.
Does fli need its own LID/context product separate from sinstro? That's doable.

collection_data_lcogt_fliraw.csv
- The LID in the first line has a typo at the end. 
  urn:nasa:pds:dart_teleobs:data_lcogt_fliraw:collection_data_lcogt_fliraw_overvie
should be
  urn:nasa:pds:dart_teleobs:data_lcogt_fliraw:collection_data_lcogt_fliraw_overview 

collection_data_lcogt_fliraw.xml
- The Observing_System section should contain at least a superset of the
context products in the data labels, so if the earlier bullet is heeded:
  urn:nasa:pds:context:facility:observatory.las_cumbres
  urn:nasa:pds:context:telescope:las_cumbres.1m0_telescopes
  urn:nasa:pds:context:instrument:las_cumbres.1m0_telescopes.sinistro
and/or .fli. What are these? I don't see their documentation in the bundle.
  <name>LCOGT 1m0-10 Telescope</name>
  <name>LCOGT 1m0-12 Telescope</name>
  <name>LCOGT 1m0-13 Telescope</name>
If those are specific telescopes, EN will gladly help build the context
products and LIDs for them, then this label can add lid_references, and the
data labels in their respective directories can also add those lid_references.



urn:nasa:pds:dart_teleobs:data_lcogtcal::1.0

*.xml
- Please replace
  urn:nasa:pds:context:instrument_host:las_cumbres.1m0_telescopes
with the existing:
  urn:nasa:pds:context:telescope:las_cumbres.1m0_telescopes

collection_data_lcogtcal.xml
- Suggestion: the lid_references in this file should at least be a union
of those in its data labels, so add lid_references to:
  urn:nasa:pds:context:facility:observatory.las_cumbres
  urn:nasa:pds:context:instrument:las_cumbres.1m0_telescopes.sinistro
as well as (hopefully)
  urn:nasa:pds:context:telescope:las_cumbres.1m0_telescopes