DART DRACO Raw, Calibrated, Derived, and Documentation Liens
============================================================

Documentation
=============

--> If possible, have consistent spelling for keywords across the DART mission.
--> The PDFs could benefit from a auto batch edit correction for small format issues,
such as, "insert a space between words and parentheses", "add a comma after all
the e.g. and i.g.", "remove commas before ands" and spell check for small typos

file: jhuapl_dart_draco_uncalibrated_calibrated_sis_v3.pdf 
--> SIS in file editing mode, not yet cleaned
--> Update version number in the footnote
--> "Note, to show an image as an observer looking out the DRACO boresight would see, it has to be flipped vertically to place the origin at the lower left (see Section 4.1.6.2)." has to → must
--> "... at a later time" → later
--> "This issue did not not affect large numbers of images, and did not affect any images taken in the Terminal and Final Phases." Remove a "not"

file: overview*.txt
--> Documents have been updated to new versions but overview.txt still references old version. Please update overview.txt files

file: overview_data_dracoraw.txt
--> "The calibration table subtraction is effectively a bias subtraction, and improves the performance of SMART Nav targeting." remove the comma

file: dimorphos_coordinate_system_description_v2.pdf  
--> Figure 1 caption: remove the o following )
--> Figure 2 caption: remove "to the" after "anchor rock”

file: didymos_coordinate_system_description_v1.pdf  
--> 4th paragraph, p4, remove "via" or "by”
--> Figure 2 caption incomplete
--> "The coordinate system of Didymos is baesd on a shape model derived from
images taken by the Didymos" → based


Data
====

--> I/F data plane in the ddp product needs to be updated to be consistent with the current data bundle.

--> Geometry keyword values: Overall agreement as the previous version, but small discrepancy in longitudes. Turning off light time correction will remove the discrepancy. Discussed with Hari, who did the calculation in his code in an identical way as what I do in my code. Small discrepancy that should not affect the use of data, but curious why


XML Labels
==========

--> Problem when reading labels of calibration files. Also, description in labels looks weird
--> Start and stop time in image data XML are different lengths


EN Review
=========

bundle_dart_spacecraft.xml has
- If this file is under review,
  <File_Area_Text>
    <File>
      <file_name>readme.txt</file_name>
      <comment>Introduction to the bundle</comment>
    </File>
but https://sbnreview.astro.umd.edu/revpro/dart202309/dart/ has no readme.txt
- This LID is unknown:
  <lid_reference>urn:nasa:pds:context:instrument:dart.hga</lid_reference>
Please submit a context product for that LID with EN when available.

collection_data_dracoraw.xml
- Element creation_date_time must have a value, not
  <creation_date_time></creation_date_time>
- https://pds.nasa.gov/datastandards/documents/policy/PolicyOnDOI10142020.pdf
requires all bundles have a doi. For SBN, perhaps collections should.
These can be obtained from https://pds-engineering.jpl.nasa.gov/content/doi

commissioning/.../*.xml
cruise/.../*.xml & others?
- These labels have element Target_Identification but no lid_reference within.
If desired, EN can help create LIDs and context products for those targets.

commissioning/2021/336/*.xml
- These have illegal values for Target_Identification/type, e.g.
      <type>Hardware</type>
or
      <type>Instrument cover</type>
Suggestion: 'Equipment', 'Calibrator' are among the legal values.
  
commissioning/2021/341/dart_0376598300_24677_03_raw.xml
commissioning/2021/341/dart_0376598512_25819_03_raw.xml
commissioning/2021/341/dart_0376598723_28823_03_raw.xml
commissioning/2021/341/dart_0376599358_24464_03_raw.xml
commissioning/2021/341/dart_0376599569_27471_03_raw.xml
commissioning/2021/341/dart_0376599992_26784_03_raw.xml
commissioning/2021/341/dart_0376600309_25536_03_raw.xml
- these labels have elements without required attribute unit:
  <dart:exposure_time xsi:nil="true" nilReason="missing"></dart:exposure_time>
  <dart:detector1_temp xsi:nil="true" nilReason="missing"></dart:detector1_temp>
  <dart:detector2_temp xsi:nil="true" nilReason="missing"></dart:detector2_temp>
  <dart:fpe_temp xsi:nil="true" nilReason="missing"></dart:fpe_temp>
  <dart:current_18vd_supply xsi:nil="true" nilReason="missing"></dart:current_18vd_supply>
  <dart:current_33va_supply xsi:nil="true" nilReason="missing"></dart:current_33va_supply>
  <dart:current_33vd_supply xsi:nil="true" nilReason="missing"></dart:current_33vd_supply>
  <dart:current_analog_reset_supply xsi:nil="true" nilReason="missing"></dart:current_analog_reset_supply>
The attribute is required even if the value is missing.Go